hint for mapping request payload error messages #19121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Nov 8, 2023
OskarStark
reviewed
Nov 8, 2023
OskarStark
reviewed
Nov 8, 2023
OskarStark
approved these changes
Nov 8, 2023
|
Target 5.4 I guess? |
dbu
commented
Nov 9, 2023
| format. This will make the error handling output a JSON response in case of | ||
| validation errors, rather than an HTML page:: | ||
|
|
||
| #[Route('/dashboard', name: 'dashboard', format: 'json')] |
There was a problem hiding this comment.
the build fails on this. should we make it a different type of code block or do we need to add php code to make the ci happy?
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
i found the place to reference the format option and linked it.
this hint is about if there is documentation about working with the error handler in general, it would make sense to add it there. but https://symfony.com/components/ErrorHandler is empty. https://symfony.com/doc/current/controller/error_pages.html#overriding-error-output-for-non-html-formats talks about custom normalizers - maybe somewhere in that chapter a hint would make sense. |
|
Thank you David. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information is particularly important in the context of the
MapRequestPayloadbut technically not related. It is about the behaviour of the symfony error handler. If there is more documentation about the error handler and output formats, i am happy to link to that if you point me to the right place.I think it is valuable to mention this here though, as it will happen when using the feature. I almost gave up and set up some custom exception listener or whatnot to output json. Stackoverflow is full of answers proposing those to output errors as JSON.